[cfe-dev] cfe-dev Digest, Vol 45, Issue 19

[Douglas Gregor]

On Apr 15, 2011, at 12:34 PM, Matthieu Monrocq wrote:

> Hello,
> 
> I have sent the two patches with the full precomputation of the index during compilation.
> 
> I'll standardize the existing diagnostics in another patch to differentiate a functional patch from a stylistic one.

Okay, thanks.

> Also, I did not implement the fuzzy matching yet, mainly because the index is still unused, and so I would not be able to test it. I just wanted to create the index in this patch to avoid later modifications to tblgen (since it implies modifying llvm and providing two linked patches).

The fuzzy matching can come later.

> I would recommend using StringRef::edit_distance for the fuzzy match, since it's what is used for auto completion. However the names are "bare" C-Strings... would it be okay to StringRef-ize the Diagnostic interface ? Or perhaps only StringRef-ize the internals and still return C-Strings ?


Sure. StringRef'ification is general goodness.

	- Doug