[cfe-dev] Fix for Clang PR 8426, 8427, & 8433

[Zhanyong Wan (λx.x x)]

Hi Ted and Doug,

On Thu, Oct 28, 2010 at 11:24 AM, Douglas Gregor <dgregor at apple.com> wrote:
>
> On Oct 27, 2010, at 11:15 PM, Zhanyong Wan (λx.x x) wrote:
>
>> Hi Ted,
>>
>> On Wed, Oct 27, 2010 at 5:55 PM, Ted Kremenek <kremenek at apple.com> wrote:
>>> Hi Zhanyong,
>>>
>>> Thanks for working on this.  I admit that I haven't had a chance to investigate those PRs myself.
>>>
>>> The changes look good, but I had two questions/comments.
>>>
>>> (1) Do we even want to be analyzing template definitions (as opposed to instantiations)?  It seems like we'd be doing a bunch of guess work.  It also seems like a performance issue if we analyze template code that is never used.
>>
>> I agree that there's little point analyzing template definitions.  It
>> would be a quite invasive change to stop doing that though, so I'd
>> like to get this patch in before attempting that.
>
>
> How is such a change invasive? One can just check whether a FunctionDecl is a dependent context (FunctionDecl::isDependentContext()), and ignore it if it is.
>
>        - Doug

Thanks for the tips.  I've uploaded a new patch to the same URL (also
attached in this message) to skip function templates in static
analysis.  Could you take a look?  Thanks,

-- 
Zhanyong
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr8426.patch
Type: text/x-patch
Size: 2159 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20101029/bd4a91c2/attachment.bin>