[cfe-dev] Fix for Clang PR 8426, 8427, & 8433

[Ted Kremenek]

Hi Zhanyong,

Thanks for working on this.  I admit that I haven't had a chance to investigate those PRs myself.

The changes look good, but I had two questions/comments.

(1) Do we even want to be analyzing template definitions (as opposed to instantiations)?  It seems like we'd be doing a bunch of guess work.  It also seems like a performance issue if we analyze template code that is never used.

(2) I'd prefer to keep the test cases in one file, for faster processing by 'make test'.  These can easily go into misc-ps-region-store.cpp.  Each test case just needs a comment indicating the PR.

Ted

On Oct 27, 2010, at 4:45 PM, Zhanyong Wan (λx.x x) wrote:

> Hi Ted,
> 
> I have a fix for Clang static analyzer bugs 8426, 8427, & 8433 (they
> turned out to be caused by the same thing).  The patch is attached.  I
> also uploaded them to http://codereview.appspot.com/2716044/ for easy
> viewing/reviewing.  Would you be able to review it?  Thanks.
> 
> I have commit privilege, so I can commit it myself when you are OK
> with it.  Thanks.
> 
> --
> Zhanyong
> <pr8426.patch>