[cfe-dev] CUDA patch series 2 (was Re: Proposal: CUDA support; outline, initial patches)

[Chris Lattner]

On Nov 29, 2010, at 9:00 PM, Peter Collingbourne wrote:

>> 
>> In this patch, please use attribute names like attribute(cuda_device) etc instead of just "device" to avoid ambiguity.
> 
> The problem with renaming the attributes is that the nvidia SDK headers
> use the plain attribute names without the cuda_.  It's important that
> we are able to parse those headers to use clang as a frontend for
> unmodified CUDA programs.  Instead, we could rename the Attr classes
> to CUDA*Attr and keep the spelling attributes as they are.

Sounds great to me. Parsing "kernel" to CUDAKernelAttr is the right approach when in cuda mode.

>> The prerequisite for that is to add a cuda language mode.
> 
> Yes, that will be patches 1, 2 from series 3.

Ok, but please start this patch series by adding cuda language mode.

-Chris