[cfe-dev] [patch] Fix access computation of default arguments in template classes

Douglas Gregor dgregor at apple.com
Mon Nov 29 08:26:31 PST 2010


On Nov 28, 2010, at 3:32 PM, Nico Weber wrote:

> Hi,
> 
> the attached patch fixes http://http://llvm.org/pr8479 "clang
> evaluates visibility of default parameters at the call site instead of
> at parameter definition site".
> 
> The problem was that Sema::BuildCXXDefaultArgExpr didn't update the
> current decl context before calling SubstExpr(), so that the default
> parameter access was checked with the decl context of the template
> instantiation site. Please review.

Looks great, thanks!

	- Doug



More information about the cfe-dev mailing list