[cfe-dev] patch: refactoring AddStmtChoice

Zhanyong Wan (λx.x x) wan at google.com
Tue Nov 23 17:23:20 PST 2010


Hi Ted,

I have a patch that refactors class AddStmtChoice to make it easier to
use.  Please see http://codereview.appspot.com/3295041

The idea is that this class actually represents *two* orthogonal
concerns.  By adding methods to manipulate one concern without
affecting the other, we allow the call sites to only specify the bit
of information they care about -- this makes the code more declarative
and simpler.

I also added your explanation on how this class works as comments.  Thanks,

-- 
Zhanyong



More information about the cfe-dev mailing list