[cfe-dev] fix for Clang PR 8419

[Ted Kremenek]

When I meant "public" versus "private", LookupExpr is used only within Environment, while GetSVal() and ValueManager are used throughout the analyzer.  Passing ValueManager around for methods that return an SVal is fairly common practice.

On Nov 20, 2010, at 1:24 AM, Zhanyong Wan (λx.x x) wrote:

>> Also, LookupExpr is a private detail of the class.  Comparing GetSVal to
>> LookupExpr is a little weird when it comes to documenting a method used by
>> clients.
> 
> I'll remove the reference to LookupExpr.
> 
> Since the ValueManager object appears in the public API (as an
> argument of the function), we cannot really say it's an implementation
> detail (the user of this function needs to know what ValueManager
> object to pass in and what the function will do to it -- even if he
> doesn't care about how the function is implemented.)  Therefore I
> think we need to explain what it's for.