[cfe-dev] fix for Clang PR 8419

Ted Kremenek kremenek at apple.com
Sat Nov 20 11:25:35 PST 2010


On Nov 20, 2010, at 12:51 AM, Zhanyong Wan (λx.x x) wrote:

> 1. I tried to move the test cases to misc-ps.m as you suggested, but
> that resulted in errors like 'class' is not a valid type name.  I
> don't know Objective-C and Objective-C++, so I have no idea how to fix
> that.  Therefore I'm leaving the test cases in
> misc-ps-region-store.cpp.

Ah, right.  The test is for C++ code!

> 
> 2. I also made some cosmetic changes to VisitBinaryOperator() to make
> it conform to the LLVM coding standards ("no 'else' after a
> 'return'").  I can take them out or move them to a new patch if you
> prefer.

Ok, thanks.  Please commit those changes in a separate patch, so the functionality change is isolated in its own patch.



More information about the cfe-dev mailing list