[cfe-dev] SourceRange for QualifiedTypeLoc

[Abramo Bagnara]

Il 20/05/2010 19:10, John McCall ha scritto:
> 
> On May 20, 2010, at 6:05 AM, Abramo Bagnara wrote:
> 
>> Il 20/05/2010 12:11, Abramo Bagnara ha scritto:
>>> Il 19/05/2010 21:43, John McCall ha scritto:
>>>>
>>>> ...also, the names aren't great;  I wouldn't object to a couple of renames:
>>>> getSourceRange -> getLocalSourceRange
>>>> getFullSourceRange -> getSourceRange
>>>
>>> Done in r104220.
> 
> Thanks.
> 
>> I'm under the impression that *every* use of getLocalSourceRange outside
>> TypeLoc.hh and TypeLoc.cpp is bogus...
> 
> No;  the index support uses it legitimately in order to narrow down where the
> query location is.
> 
> Feel free to rework that code if it makes your task easier;  just keep in mind that
> its performance is quite important.

I've attached the patch to fix typeloc sourcerange for review/approval.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: TypeLocRange.patch
Type: text/x-patch
Size: 1861 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20100521/34cfdbd8/attachment.bin>