[cfe-dev] SourceRange for QualifiedTypeLoc

John McCall rjmccall at apple.com
Thu May 20 10:09:02 PDT 2010


On May 20, 2010, at 6:05 AM, Abramo Bagnara wrote:

> Il 20/05/2010 12:11, Abramo Bagnara ha scritto:
>> Il 19/05/2010 21:43, John McCall ha scritto:
>>> 
>>> ...also, the names aren't great;  I wouldn't object to a couple of renames:
>>>  getSourceRange -> getLocalSourceRange
>>>  getFullSourceRange -> getSourceRange
>> 
>> Done in r104220.

Thanks.

> I'm under the impression that *every* use of getLocalSourceRange outside
> TypeLoc.hh and TypeLoc.cpp is bogus...

No;  the index support uses it legitimately in order to narrow down where the
query location is.

Feel free to rework that code if it makes your task easier;  just keep in mind that
its performance is quite important.

John.



More information about the cfe-dev mailing list