[cfe-dev] [PATCH] PCH Support for C++ decls

[Andrew Sutton]

> It would be much easier to handle such additions as separate patches once
> the main patch has gone in. Big patches take much longer to review. We
> haven't quite dealt with all of the issues there yet.
>

I realized that after I re-posted it. I can try to break it down into more
digestible pieces.


> Also, friends are in a state of flux, so it's not worth trying to
> (de-)serialize them now. Once the AST settles down and access control is
> turned on by default, it will make sense to implement PCH support with
> friends.
>

Sounds good. I'll try to take out the friend stuff.

> The DefinitionData isn't attached but the previous declaration is set
> correctly. IIRC, the same situation happens with injected class names.
>
> Since you posted the original patch, a better solution has come up. When we
> start a definition of a CXXRecordDecl, we go back and fix up all of the
> DefinitionData pointers.
>

That is a better solution :)


> Only the 2.7 branch of Clang/LLVM is in code freeze. The trunk is in its
> usual frenzy of activity.
>
> Overall, this patch isn't quite ready to go in.
>

> I think fixing conversion functions and the ctor-initializers are crucial
> for this patch to go in.
>

Sounds good. I'll take another turn on it. Unfortunately, I'm pretty busy
for the next week or so. Maybe extending PCH support for clang (expressions,
too) would make a good GSoC project :)

Andrew Sutton
andrew.n.sutton at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20100329/10f5813c/attachment.html>