[cfe-dev] Macro expansion weirdness (or bug?)

[Chris Lattner]

On Mar 26, 2010, at 1:44 AM, Abramo Bagnara wrote:

> Il 26/03/2010 00:32, Abramo Bagnara ha scritto:
>> Il 25/03/2010 20:43, Chris Lattner ha scritto:
>>> 
>>> On Mar 25, 2010, at 12:08 PM, Abramo Bagnara wrote:
>>> 
>>>> 
>>>> From your message it seems you're expecting *more* callback
>>>> invocations in the first sample, while I'd expect *less* callback
>>>> invocations in the second sample.
>>>> 
>>>> Could you explain better your position?
>>> 
>>> My position is basically that the preprocessor is incredibly
>>> scary/confusing and implementing it damaged me.  :)
>>> 
>>> I don't recall enough of the details to really say which way is right
>>> or wrong, but tokens coming out at -E is a good indicator that the
>>> right thing is happening.
>> 
>> Indeed it was missing further expansion disabling in a case where
>> isTrivialSingleTokenExpansion is true.
> 
> Please apply also this unrelated patch fixing a typo in paste avoidance
> code.

nice catch, applied in r99624 with a testcase.

-Chris