[cfe-dev] [patch] Microsoft Extension - #pragma message

[Chris Lattner]

On Jun 24, 2010, at 9:33 AM, Michael Spencer wrote:

> On Wed, Jun 23, 2010 at 1:52 AM, Chris Lattner <clattner at apple.com> wrote:
>> Hi Michael,
>> 
>> Thanks for working on this.  This looks good with two minor changes:
>> 
>> 1) please drop the testcase into the Lex directory instead of making a new MicrosoftExtensions directory for it.  The MS testcases can be found by grepping for ms-extensions.
>> 
>> 2) Though it almost certainly isn't a performance issue, for code cleanliness, please change "PragmaMessage" to take a StringRef by value instead of taking a std::string.  This will allow PP::HandlePragmaMessage to pass the string directly from the literal parser instead of indirecting through the std::string.
>> 
>> Thanks again,
>> 
>> -Chris
> 
> Changes made and new patch attached.

Looks great, applied in r106950, thanks again!

> Would you like those same changes
> made to PragmaComment? That's the style I followed for PragmaMessage.

Yes please!  It looks like it is going back to pre-stringref style.  Thanks Michael,

-Chris