[cfe-dev] [PATCH] Make libcxx compile on x86_64 Linux w/ g++ 4.4.3

[Howard Hinnant]

On Jun 2, 2010, at 11:39 AM, Jeffrey Yasskin wrote:

> When I was fixing these problems (sorry for missing the move case), I
> used "0" instead of either NULL or nullptr. That's not guaranteed to
> work either, and I didn't check glibc to see if it's actually the
> not-a-thread value, but it at least made things compile.

> 
> Howard, is there a reason you're using pthread_t and literal no-thread
> values everywhere instead of using thread::id? Using thread::id
> everywhere would reduce the number of places that need porting.

Yes.  I like to minimize levels of inlining when the cost to do so is low.  It makes non-optimized (e.g. debug) builds run faster which in turn can make the entire customer development process faster/more livable.

I did think about using thread::id as you suggest, but found the cost of not doing so acceptable.

-Howard