[cfe-dev] Patch: wchar_t support

Daniel Dunbar daniel_dunbar at apple.com
Thu Jul 1 08:34:28 PDT 2010

On Jun 30, 2010, at 4:03 PM, Nico Weber wrote:

> On Fri, Jun 11, 2010 at 3:12 AM, John McCall <rjmccall at apple.com> wrote:
>> On Jun 10, 2010, at 9:46 PM, Nico Weber wrote:
>>> the attached patch lets @encode(wchar_t) not crash (with test case). The returned value matches g++, which returns "i" for both i386 and x86_64 archs.
>> I committed this part, thanks!
>>> The patch also makes one of lits error messages less confusing.
>> I didn't commit this part;  it looks reasonable to me, but Daniel should weigh in.
> Daniel, what do you think of the lit patch? Would've saved me some 5
> minutes back then.

Sure, looks fine. I would phrase it:
        lit.fatal('No site specific configuration available! You may need to run 'make test' in your Clang build directory.')

 - Daniel

>> John.

More information about the cfe-dev mailing list