[cfe-dev] Missing service for CommentHandlers

[Douglas Gregor]

On Jan 27, 2010, at 1:43 AM, Abramo Bagnara wrote:

> (Resent using another subscription, the other address seems to not find
> its way to the list. Sorry for possible duplicates).
> 
> Recently it has been commited a patch to allow comment handlers to enter
> token in the preprocessed stream, but AFAICT we lack the possibility for
> handlers to know if the preprocessor is currently skipping an excluded
> block.
> 
> Currently if the comment handler enter tokens also when preprocessor is
> skipping, these token are not consumed by SkipExcludedConditionalBlock
> and then will be read on exit of this function (obviously this is wrong).
> 
> We have some alternative way to cope with this problem:
> 
> 1) make SkipExcludedConditionalBlock to consume also the tokens from
> CurTokenLexer

This seems like the right approach to me. 

	- Doug