[cfe-dev] [PATCH] and getting started

[dawn at burble.org]

PS: corrected patch attached

On Wed, Aug 25, 2010 at 11:53:22AM -0700, dawn at burble.org wrote:
> 
> I'd like to a submit the attached simple patch for review to get
> familiar with the clang commit process.  The instructions at
> http://llvm.org/docs/DeveloperPolicy.html say "When sending a patch to
> a mailing list" but don't actually come out and say that one should
> start by submitting a patch to this mailing list :-).  Please correct me
> (and the web site) if I got it wrong.
> 
> Thanks!
> -Dawn

> Index: lib/Sema/SemaOverload.cpp
> ===================================================================
> --- lib/Sema/SemaOverload.cpp	(revision 110949)
> +++ lib/Sema/SemaOverload.cpp	(working copy)
> @@ -2119,6 +2119,7 @@
>    return ImplicitConversionSequence::Indistinguishable;
>  }
>  
> +int die() { /*printf("hi\n");*/ return 0; }	//DAWN
>  static bool hasSimilarType(ASTContext &Context, QualType T1, QualType T2) {
>    while (Context.UnwrapSimilarPointerTypes(T1, T2)) {
>      Qualifiers Quals;
> Index: lib/Lex/Preprocessor.cpp
> ===================================================================
> --- lib/Lex/Preprocessor.cpp	(revision 112066)
> +++ lib/Lex/Preprocessor.cpp	(working copy)
> @@ -531,7 +531,7 @@
>    // Preprocess Predefines to populate the initial preprocessor state.
>    llvm::MemoryBuffer *SB =
>      llvm::MemoryBuffer::getMemBufferCopy(Predefines, "<built-in>");
> -  assert(SB && "Cannot fail to create predefined source buffer");
> +  assert(SB && "Cannot create predefined source buffer");
>    FileID FID = SourceMgr.createFileIDForMemBuffer(SB);
>    assert(!FID.isInvalid() && "Could not create FileID for predefines?");
>  

> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev

-------------- next part --------------
Index: lib/Lex/Preprocessor.cpp
===================================================================
--- lib/Lex/Preprocessor.cpp	(revision 112066)
+++ lib/Lex/Preprocessor.cpp	(working copy)
@@ -531,7 +531,7 @@
   // Preprocess Predefines to populate the initial preprocessor state.
   llvm::MemoryBuffer *SB =
     llvm::MemoryBuffer::getMemBufferCopy(Predefines, "<built-in>");
-  assert(SB && "Cannot fail to create predefined source buffer");
+  assert(SB && "Cannot create predefined source buffer");
   FileID FID = SourceMgr.createFileIDForMemBuffer(SB);
   assert(!FID.isInvalid() && "Could not create FileID for predefines?");