[cfe-dev] adding FileSkipped() to PPCallbacks

Chris Lattner clattner at apple.com
Fri Apr 16 13:50:07 PDT 2010


On Apr 16, 2010, at 1:40 PM, Abramo Bagnara wrote:

> Il 16/04/2010 20:48, Zhanyong Wan (λx.x x) ha scritto:
>> Hi Doug,
>> 
>> Per our IRC chat yesterday, I'm extending PPCallbacks with a new
>> method FileSkipped() to notify a listener when a #include is skipped
>> due to header guard optimization.  Please see the attached patch and
>> let me know if this is the right direction.  (I verified that it works
>> for my use case.)  Also, how should I add a test for this?
> 
> We have encountered a similar problem concerning the lack of PPCallbacks
> for skipped excluded conditional blocks.
> 
> Do you see some problems in adding such a callback?

Adding a callback for skipped #if blocks would be fine.



More information about the cfe-dev mailing list