[cfe-dev] adding FileSkipped() to PPCallbacks

Zhanyong Wan (λx.x x) wan at google.com
Fri Apr 16 12:44:29 PDT 2010

On Fri, Apr 16, 2010 at 12:21 PM, Douglas Gregor <dgregor at apple.com> wrote:
> On Apr 16, 2010, at 11:48 AM, Zhanyong Wan (λx.x x) wrote:
>> Per our IRC chat yesterday, I'm extending PPCallbacks with a new
>> method FileSkipped() to notify a listener when a #include is skipped
>> due to header guard optimization.  Please see the attached patch and
>> let me know if this is the right direction.  (I verified that it works
>> for my use case.)  Also, how should I add a test for this?
> Looks good. I have no idea how to test this, since we don't have any way for preprocessor callbacks to show up in any of Clang's output. It's okay to commit something this small without a test.

Thanks, Doug.  I don't have the right to commit.  Would you commit the
patch for me?  Thanks,


More information about the cfe-dev mailing list