[cfe-dev] please review: fix for http://llvm.org/PR4407
Zhanyong Wan (λx.x x)
wan at google.com
Wed Oct 14 13:48:23 PDT 2009
Hi,
I have a patch that fixes the first issue in http://llvm.org/PR4407 :
Clang should warn on a case value that exceeds the range of the type in
switch.
const char ch = 'a';
switch(ch) {
case 1234: // expected-warning {{overflow converting case value}}
break;
}
I uploaded the patch to http://codereview.appspot.com/130078/show.
Could someone review it?
This is the first time I work on clang, so please let me know if I'm
following the coding convention correctly. Thanks,
--
Zhanyong
More information about the cfe-dev
mailing list