[cfe-dev] Windows patches

[Mike Stump]

On Oct 9, 2009, at 1:12 PM, John Thompson wrote:
> Here's another crack at the windows include paths patch

-/// RemoveDuplicates - If there are duplicate directory entries in  
the specified
-/// search list, remove the later (dead) ones.
+/// RemoveDuplicates - If there are duplicate directory entries in the
+/// specified search list, remove the later (dead) ones.

No, this was fine before.  Be sure to set your reflow column to be 80.


+bool getSystemRegistryString(const char *keyPath, const char  
*valueName,
+                       char *value, size_t maxLength) {
+  (void)keyPath;
+  (void)valueName;
+  (void)value;
+  (void)maxLength;
+  return(false);
+}

No, just omit the parameter name in the definition instead of cast to  
(void).


About the CMakeLists.txt change, ick.  Too much cut-n-paste  
programming.  If there is a way to say add this flag for this  
translation unit, that'd be best, second best would be to say, remove  
this flag for just this unit.  I was hoping there'd be a way to do  
that in just a few lines (like two, something like remove_flag 
(InitHeaderSearch.cpp, /Za)) or some such.  I'h hoping a cmake person  
can suggest something better.  Barring that, can you set a flag, check  
that in that flag in add_clang_library, and omit adding the /Za option?