[cfe-dev] Windows patches

Mike Stump mrs at apple.com
Thu Oct 8 16:33:25 PDT 2009


On Oct 8, 2009, at 12:08 PM, John Thompson wrote:
>
> include/clang/Frontend/InitHeaderSearch.h:
> lib/Frontend/InitHeaderSearch.cpp:
> tools/clang-cc/clang-cc.cpp:
>
> This is a slight revision to the patch I posted yesterday to have  
> the default include path code use the target triple, as the line  
> numbers were off due to some other changes.  It also sets up include  
> paths for VC++ and Cygwin headers, along with the existing MinGW  
> headers, plus the newer 4.4.0 version.  Note that running the tests  
> with the MinGW headers results in 40 or more failed tests.   
> Currently, with this patch, only 23 tests are failing with the VC++  
> headers.  I did leave in some disabled code regarding the question I  
> posted yesterday about including windows.h for the registry stuff.

I've checked this in, along with some minor whitespacing issues.   
Please keep lines to 80 columns.  Also, be sure to detab the files as  
well.  In some editors, there is a setting to avoid the use of hard  
tabs.

I think the windows code should be boosted out to a new file, and  
hidden away from us mere mortals.  In general #if in files is to be  
discouraged.



More information about the cfe-dev mailing list