[cfe-dev] [PATCH] PR5326, Clang needs support for _Complex_I and _Imaginary_I as intrinsics.

Edward O'Callaghan eocallaghan at auroraux.org
Fri Nov 27 14:19:43 PST 2009


Thanks for the pointer Eli !

Please see attached update, I can't seem to get it work work as expected.

-bash-3.2$ ../../llvm/Debug/bin/clang-cc -fsun-extensions divdc3_test.c
clang-cc: Unknown command line argument '-fsun-extensions'.  Try:
'../../llvm/Debug/bin/clang-cc --help'

I must be missing something somewhere, can you please review my patch carefully?

Thanks for your time,
Edward.

2009/11/27 Eli Friedman <eli.friedman at gmail.com>:
> On Fri, Nov 27, 2009 at 12:33 AM, Edward O'Callaghan
> <eocallaghan at auroraux.org> wrote:
>> http://llvm.org/bugs/show_bug.cgi?id=5326
>>
>> G'Day,
>>
>> In regards to PR 5326,
>>
>> Would someone to be willing to give me some feedback and what else may
>> need to be done on my current patch please?
>> See: http://llvm.org/bugs/attachment.cgi?id=3715
>
> The patch looks correct as far as it goes.
>
> Instead of making _Complex_I a keyword, you could just #define it to
> the GNU equivalent in the predefines; it's not precisely correct, but
> it's a lot less work to get it working.  If you want to get it working
> cleanly, I guess the next step would be making
> Parser::ParseCastExpression actually handle _Complex_I, then adding an
> AST node, then adding Sema and CodeGen handling.
>
> -Eli
>



-- 
--
Edward O'Callaghan
http://www.auroraux.org/
eocallaghan at auroraux dot org
---
()  ascii ribbon campaign - against html e-mail
/\                        - against microsoft attachments
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PR5326.patch
Type: application/octet-stream
Size: 9821 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20091127/662afe8d/attachment.obj>


More information about the cfe-dev mailing list