[cfe-dev] possibly bug in LocationCheck

Ted Kremenek kremenek at apple.com
Mon Nov 16 12:07:11 PST 2009


No, that's a bug.  It hasn't triggered anywhere yet since we don't have any instances yet of isa<LocationCheck>, but once we did this would be a serious problem.  Fixed in r88949.

Thanks so much for pointing this out!

On Nov 16, 2009, at 11:40 AM, Marius Wachtler wrote:

> Hello
> 
> I think I found a bug in clang/include/clang/Analysis/ProgramPoint.h:224.
> 
> static bool classof(const ProgramPoint *location) {
>     unsigned k = location->getKind();
>     return k == PreLoadKind || PreStoreKind;
>   }
> 
> Shouldn't it be "return (k == PreLoadKind) || (k == PreStoreKind);"?
> Or is this intended?
> 
> -- Marius Wachtler
> 
> 
> 
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev





More information about the cfe-dev mailing list