[cfe-dev] Newly failing tests on Windows, assert in PCHReader.cpp, new argument

[John Thompson]

Here's a patch which fixes the assertion failure in running the tests on
Windows, basically matching what is done for the include directive put in
the Predefines.

Should I check it in?

-John

On Wed, Nov 11, 2009 at 12:31 PM, John Thompson <
john.thompson.jtsoftware at gmail.com> wrote:

> 30 tests are failing on Windows, 27 newly since Monday.
>
> 25 of them are due to an assert at line 172 in PCHReader.cpp.
>
> The problem is that the file path appended to the Predefines has been
> converted to use double-'\', whereas the path in OriginalFileName used
> single '/'.
>
> I'm not sure which side to change.
>
> The other is in CodeGenCXX/new-operator-phi.cpp:
>
> 1>  Line 4: 'operator new' takes type size_t ('unsigned int') as first
> parameter
> I'm not sure what you want to do here, whether to change it to use size_t
> and to include stddef.h, or put in a platform conditional.
> -John
>
> --
> John Thompson
> John.Thompson.JTSoftware at gmail.com
>
>


-- 
John Thompson
John.Thompson.JTSoftware at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20091111/75ffcb3e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pchfix.patch
Type: application/octet-stream
Size: 969 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20091111/75ffcb3e/attachment.obj>