[cfe-dev] [cfe-commits] r67438 - in /cfe/trunk/lib/CodeGen: CGExpr.cpp CodeGenModule.cpp CodeGenModule.h

[Chris Lattner]

On Mar 21, 2009, at 6:05 PM, Daniel Dunbar wrote:
> simplify and comment some code better.  Make BindRuntimeGlobals
> more optimistic that it will work (optimizing for the common case).
>
> I may be missing something, but wouldn't this be cleaner if we just
> provided a Module method to return a reference to the entry for a
> name? This would avoiding the shuffling with names and only do one
> lookup.
>
> We already have this through ValueSymbolTable.  I added this  
> comment, though I don't really know if it is true:
>
> I guess I wasn't clear... I was referring to this code:

Ok, that code is now gone as of r67478.

> Ok! Although I'm curious how...
>
Please take a look!

-Chris