[cfe-dev] MSVC Ownership.h patch

[Chris Lattner]

On Jun 25, 2009, at 8:04 AM, AlisdairM(public) wrote:

>> -----Original Message-----
>> From: Douglas Gregor [mailto:dgregor at apple.com]
>> Sent: 25 June 2009 15:50
>> To: AlisdairM (public)
>> Cc: cfe-dev at cs.uiuc.edu
>> Subject: Re: [cfe-dev] MSVC Ownership.h patch
>
>> Well, we can't drop support for Visual C++ over a little bug like
>> this. I'm perfectly happy to put your patch into Clang once it has a
>> proper version check. This stuff will clean itself up once rvalue
>> references become more prevalent.
>
> Well in that case I'm going to have to ask the list what the best  
> way to identify this compiler is?
>
> As Doug knows I'm more familiar with a different brand of Windows  
> compilers, and I know lots of compilers on Windows try to look like  
> MSVC to get a clean run at the Windows headers.
>
> Is there a precedent for this elsewhere in Clang/LLVM?

We usually use "#ifdef _MSC_VER" to detect microsoft compilers.  If  
you want to detect the windows platform, use #ifdef LLVM_ON_WIN32

-Chris