[cfe-dev] Patch & feedback request

[Chris Lattner]

On Jul 27, 2009, at 8:15 AM, Sebastian Redl wrote:

> Chris Lattner wrote:
>> On Jul 26, 2009, at 9:08 AM, Mike Stump wrote:
>>
>>
>>> On Jul 26, 2009, at 7:16 AM, Erik Verbruggen wrote:
>>>
>>>> Attached is a patch
>>>>
>>> Looks good to me.  I kinda which we had all the canonicalization
>>> patches in as this would be just slightly different.  Possibly a
>>> FIXME: redo post canonicalization with the type system work...
>>>
>>> The only question I would have is, do people want a total ordering  
>>> for
>>> QualType?
>>>
>>
>> I don't see what ordering has to do with it, or what canonical types
>> do either.  He's doing type equality checks.
>>
> If you want to sort QualTypes, you need some ordering.

Right, but the predicate ("how it sorts") doesn't matter.

-Chris