[cfe-dev] [Patch] Make ParseAST() take ASTContext and TU params

[Alexei Svitkine]

If no one objects to these changes, can someone commit this to the repository?

-Alexei

On Tue, Jan 27, 2009 at 10:31 AM, Alexei Svitkine
<alexei.svitkine at gmail.com> wrote:
> On Mon, Jan 26, 2009 at 2:29 PM, Alexei Svitkine
> <alexei.svitkine at gmail.com> wrote:
>> Here's an updated patch that also removes the comment about the
>> FreeMemory param which no longer exists.
>>
>> -Alexei
>>
>> On Sat, Jan 24, 2009 at 2:51 PM, Alexei Svitkine
>> <alexei.svitkine at gmail.com> wrote:
>>> You are right. Here's a revised patch.
>>>
>>> -Alexei
>>>
>>> On Sat, Jan 24, 2009 at 11:19 AM, Sebastian Redl
>>> <sebastian.redl at getdesigned.at> wrote:
>>>> Alexei Svitkine wrote:
>>>>> Hi,
>>>>>
>>>>> Attached is a patch to make ParseAST() take ASTContext and
>>>>> TranslationUnit as parameters, as suggested by Steve Naroff.
>>>>>
>>>>
>>>> The double negative in the code confuses me somewhat, but isn't this
>>>> condition the wrong way round?
>>>>
>>>>> +    if (!DisableFree) {
>>>>> +      Context = new ASTContext(PP.getLangOptions(),
>>>>> PP.getSourceManager(),
>>>>> +                               PP.getTargetInfo(),
>>>>> +                               PP.getIdentifierTable(),
>>>>> PP.getSelectorTable());
>>>>> +      TU = new TranslationUnit(*Context);
>>>>> +    }
>>>>> +    ParseAST(PP, Consumer.get(), Context, TU, Stats);
>>>>
>>>> Previously, if DisableFree was true, FreeMemory was false, and ParseAST
>>>> didn't free the objects.
>>>> Now, if DisableFree is true, the driver doesn't allocate objects, so
>>>> ParseAST does and will free them.
>>>>
>>>> Sebastian
>>>>
>>>
>>
>