[cfe-dev] [Patch] Refactor Sema::CppLookupName

[Piotr Rak]

2009/2/6 Sebastian Redl <sebastian.redl at getdesigned.at>:
> Douglas Gregor wrote:
>>
>> On Feb 6, 2009, at 9:07 AM, Sebastian Redl wrote:
>>> How about something like
>>>
>>> // expected-diag {{...}} -> allow the diagnostic 1+ times (in order to
>>> not mess up current test cases)
>>> // expected-diag 2 {{...}}} -> demand the diagnostic exactly twice
>>
>> Great idea!
>
> OK, I'll take a stab at it over the weekend.
>
> Sebastian
>

I afraid that buys us nothing, or not much.
We would not notice such regressions, if we would not manualy change most of:

// expected-diag {{...}}
to:
// expected-diag 1 {{...}}

Later we would have to write most ensure we do that.

I would rather suggest:

// expected-diag {{...}} -> allow the diagnostic exactly 1 time

// expected-diag 2 {{...}}} -> demand the diagnostic exactly twice

Audit all tests that it breaks, if it is correct, if  not mark with
FIXME or fix.
What do you think?

Piotr