[cfe-dev] GNU runtime non-fragile ABI and cleanup
Fariborz Jahanian
fjahanian at apple.com
Sun Aug 30 11:12:07 PDT 2009
Few comments:
+
+ ObjCConstantStringClass = "NXConstantString";
This is specific to Gnu runtime and initialization should happen for
when in Gnu-specific runtime mode.
-OPTION("-pthread", pthread, Flag, INVALID, INVALID, "", 0, 0, 0)
+OPTION("-pthread", pthread, Flag, INVALID, INVALID, "q", 0, 0, 0)
Unrelated to this patch. Please provide a separate patch for this (and
a test case) if you want it.
@@ -818,6 +824,9 @@
else if (GNURuntime)
Options.NeXTRuntime = 0;
+ if (!ObjCConstantStringClass.empty())
+ Options.ObjCConstantStringClass = ObjCConstantStringClass.c_str();
+
This should happen when in GNURuntime. For other runtimes please issue
a warning that option is not supported.
Please provide a test case for this patch.
- Thanks, Fariborz
On Aug 29, 2009, at 7:01 PM, David Chisnall wrote:
> Updated version of the diff tidies up a few more things, and adds
> support for the -fconstant-string-class= flag (GCC-compatibility).
>
> David
>
> On 29 Aug 2009, at 23:52, David Chisnall wrote:
>
>> Hi,
>>
>> The attached diff removes the MakeConstantString() method from
>> CGObjCGNU and replaces uses to it with the equivalent method in
>> CodeGenModule. It also updates the non-fragile ABI implementation.
>>
>> David
>> <clang.diff>
>
> <clang.diff>_______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
More information about the cfe-dev
mailing list