[cfe-dev] CharacterLiteral get/set location.

Chris Lattner clattner at apple.com
Mon Aug 24 10:39:53 PDT 2009


On Aug 24, 2009, at 10:32 AM, Enea Zaffanella wrote:

> Chris Lattner wrote:
>> On Aug 24, 2009, at 5:46 AM, Enea Zaffanella wrote:
>>> Class CharacterLiteral has the following public methods, which are  
>>> inconsistently named:
>>>
>>> SourceLocation getLoc() const { return Loc; }
>>> void setLocation(SourceLocation Location) { Loc = Location; }
>>>
>>> The attached patch makes these names consistent.
>> Looks great, please attach the patch as an attachment (instead of  
>> inline) to make it easier to apply. Thanks!
>> -Chris
>
> Second attempt, after playing with mailer options.

Thanks, applied as r79924!

-Chris



More information about the cfe-dev mailing list