[cfe-dev] casts.c, Windows issues

[John Thompson]

> This test [cast.c] should just be updated to not use that header, it shouldn't
> be necessary.

Okay.  I submitted to cfe-commits a patch that just disables the part
of the test that uses the socket stuff.  Is this enough, or should I
replace it with something equivalent?  I'm just anxious to have the
tests pass on Windows.

>
>> One issue is the need for the Windows Platform SDK to be added to the
>> default include paths.  This patch includes my former changes to the
>> default include paths for Windows, plus additional code for adding the
>> platform SDK.  Therefore, you can disregard my previous submissions
>> regarding InitHeaderSearch.cpp if you use this patch.  Also, if anyone
>> has a better mechanism of finding the Visual Studio and Platform SDK
>> includes, such as through the registry, please let me know.

Any comments about this?

> There is more to this, this makes the fields of MONITORINFO available
> in this struct. The right fix is to implement this feature under
> -fms-extensions. I think that this should be fairly easy, since we
> already support the inline case:

Oh, sorry, I didn't pick up on this.  I can take a whack at this
later, if someone doesn't get to it first.  Right now I want to do
something about the failing tests on Windows.

> These defines should only be added on Windows, see
> WindowsX86_32TargetInfo. Can you submit this part as a separate patch?

I submitted a patch for this to cfe-commits.  I guess Win64 is
something for later.

>  - Daniel

Thanks for reviewing this, Daniel.

-- 
John Thompson
John.Thompson.JTSoftware at gmail.com