[cfe-dev] Fix for PR4701

[Daniel Dunbar]

Hi David,

I'd like to sort out what we are doing with IsaExpr. I still don't see
a reason to complicate codegen and other clients with this expression.
This could just be because I don't want to implement support for it
(*grin*), but I think that if we really care about being future
looking we would move people to runtime functions; a custom expression
node for syntax which is identical to other general language syntax is
pretty gross...

Also, I noticed a regression with this patch, the problem stems from this:
--
+    if (BaseType != Context.ObjCIdRedefinitionType) {
+      BaseType = Context.ObjCIdRedefinitionType;
--
is this supposed to be ==? Otherwise it doesn't make sense, since
Context.ObjCIdRedefitionType gets initialized to the null QualType.

 - Daniel

On Mon, Aug 17, 2009 at 5:58 AM, David Chisnall<csdavec at swansea.ac.uk> wrote:
> On 15 Aug 2009, at 00:51, steve naroff wrote:
>
>> Given the number of fields, it sounds like we should go with your
>> least disruptive solution to this. You've convinced me that my
>> original suggestion is unlikely to scale to 23 fields...
>>
>> Oh well. Given the amount of time I spent on this "cleanup", I hate to
>> add cruft (but we need to support the legacy idioms I suppose...).
>
> Is it okay if I commit this patch?  Then we can start ironing out any
> issues that arise.
>
> David
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>