[cfe-dev] codegening constants

Nuno Lopes nunoplopes at sapo.pt
Mon Sep 1 04:37:52 PDT 2008


> On Aug 27, 2008, at 9:41 PM, Eli Friedman wrote:
>>>> From my quick testing I think I was getting 'correct' results.  
>>>> Anyway I
>>>> include a second patch in attach that uses the methods in  
>>>> ASTContext. (I
>>>> dunno why I missed those on the first time..).
>>>> What do you think about this second version?
>>>
>>> This patch looks great to me.  Eli, is this sufficient to handle  
>>> the cases
>>> you know of?
>>
>> It looks correct to me; I can't think of any cases where this isn't
>> the right thing.
> 
> Me neither, please apply Nuno, thanks!

commited!
thanks for reviewing,
Nuno



More information about the cfe-dev mailing list