[cfe-dev] function.diff [Re: Continuing Adventures with Objective-C]

[Devang Patel]

On May 13, 2008, at 9:22 AM, David Chisnall wrote:

> function.diff pulls shared code from CodeGenFunction::GenrateCode  
> and GenerateObjCMethod out.

Yay! Pl. co-ordinate with Sanjiv who is adding debug info support and  
updating this part in recent patch.

> It also removes the method for generating ObjC methods from  
> CodeGenFunction.

> -llvm::Value *CodeGenFunction::LoadObjCSelf(void)
> -{
> -  if(const ObjCMethodDecl *OMD =  
> dyn_cast<ObjCMethodDecl>(CurFuncDecl)) {
> -    llvm::Value *SelfPtr = LocalDeclMap[&(*OMD->getSelfDecl())];
> -    return Builder.CreateLoad(SelfPtr, "self");
> -  }
> -  return NULL;
> -}

What about  LoadObjCSelf uses ?
Otherwise, patch is OK.
Thanks!
-
Devang