[cfe-dev] add a valgrind option to "make test"

[Gabor Greif]

Thanks Sam!

There is some problem though:

cat: Output/Parser/implicit-casts.c.out.vg.*: No such file or directory
// repeated many times //

this is on darwin.

The patch applied, but I did not check it in because of this.

Can you imagine what is going wrong?

Cheers,

	Gabor



Am 20.03.2008 um 22:37 schrieb Sam Bishop:

> Hi, Gabor.
>
> On Thu, March 20, 2008 9:59 am, Gabor Greif wrote:
>> Sam Bishop wrote:
>>> ...
>> In the last days I have tweaked a lot on "make test", but now it  
>> should
>> be stable enough for you to get this in. My apologies not coming  
>> back to
>> you earlier.
>
> No problem.  And thank you for the review!
>
>>>  SCRIPT=$OUTPUT.script
>>> -grep 'RUN:' $FILENAME | sed
>>> "s|^.*RUN:\(.*\)$|\1|g;s|%s|$SUBST|g;s|%llvmgcc|llvm-gcc
>>> -emit-llvm|g;s|%llvmgxx|llvm-g++
>>> -emit-llvm|g;s|%prcontext|prcontext.tcl|g" > $SCRIPT
>>> +grep 'RUN:' $FILENAME | \
>>> +  sed -e "s|^.*RUN:\(.*\)$|\1|g" \
>>> +      -e "s|%s|$SUBST|g" \
>>> +      -e "s|%llvmgcc|llvm-gcc -emit-llvm|g" \
>>> +      -e "s|%llvmgxx|llvm-g++ -emit-llvm|g" \
>>> +      -e "s|%prcontext|prcontext.tcl|g" \
>>> +      -e "s|clang|$CLANG|g" > $SCRIPT
>>
>> nice cleanup. meanwhile I have added a new %t substitution, please  
>> add
>> that too.
>
> I made a %t1 -> %t substitution in a TestRunner.sh comment.  I'm not
> 100% sure about it, though.  Feel free to back that out if it's wrong.
>
>>> -	PATH=$$PATH:$(ToolDir):$(LLVM_SRC_ROOT)/test/Scripts \
>>> +	PATH=$$PATH:$(ToolDir):$(LLVM_SRC_ROOT)/test/Scripts VG=${VG} \
>>
>> Why do you use wiggly brackets in ${VG}. The file uses parentheses,
>> let's stick to them.
>
> Oops.  Personal habit.  Fixed.
>
>> Btw. test/Makefile is obsolete and will go away soon. Please apply  
>> the
>> change to test/Makefile.parallel too.
>
> Yeah, I thought I'd wait 'til things settled down.  Done.
>
> Thanks again!
>
> Sam<valgrind-make-test-v3.patch>