[cfe-dev] "Fixes" for two crashes, rant on Tok.getIdentifierInfo() and two more bugs

[Fariborz Jahanian]

On Dec 27, 2007, at 12:11 PM, Chris Lattner wrote:
>
>> An unrelated crash that I found on the way is:
>>
>>    int main()
>>    {
>>      id a;
>>      [a bla:0 6:7];
>>    }
>>
>> (crashes somewhere in sema, something like this should be put in  
>> test/Parse/objc-messaging-1.m)

Should produce error not crash :). I look take a look.

>>
>>
>>
>> And here's an inconsistency with gcc:
>>
>>    int @interface bla ;  // ?? this is valid objc?
>>    @end
>>
>> I have no idea what this code is supposed to do, but it doesn't  
>> warn with clang but doesn't even compile with gcc.

This is invalid and should produce an error. However,

@interface bla ;
@end

(optional ';' is OK !!

- Fariborz


>
> I'll let Steve and Fariborz chime in on these.
>
>> ps: I also converted a few tabs to spaces
>
> Thanks!  It would make it easier to review the patch if you kept the  
> mechanical pieces separate from the changes that require review, but  
> I appreciate the patch.
>
> As an aside, things will probably pick up in early january, many  
> people are out for the holidays.
>
> -Chris