[cfe-dev] C++ using-directive parsing

[Piotr Rak]

2008/12/29 Douglas Gregor <dgregor at apple.com>:
> On Dec 28, 2008, at 12:32 AM, Piotr Rak wrote:
>>
>> 2008/12/27 Douglas Gregor <dgregor at apple.com>:
>
> +  } else {
> +    Diag(IdentLoc, diag::err_expected_namespace_name);
> +    // FIXME: if SS.isSet() we could note about NamespcName not being
> +    // member of DC, or not namespace name.
> +  }
>
> Instead of mentioning DC (which means trying to format it into a readable
> name in the error message), I suggest just underlying the range with, e.g.,
>
>        Diag(IdentLoc, diag::err_expected_namespace_name) <<
> SS.getSourceRange();

I meant additional giving note something like: 'C is not member of D::B'

> Anyway, these are minor things. If you would send the updated
> cxx-using-directive.cpp test case you mentioned, I'll be happy to integrate
> your patch into the Clang repository. Thanks!
>
>        - Doug

Sorry, about that, attached now!

Piotr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cxx-using-directive.cpp
Type: text/x-c++src
Size: 768 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20081229/fd73caf0/attachment.cpp>