[cfe-dev] C++ using-directive parsing

[Sebastian Redl]

Piotr Rak wrote:
> 2008/12/27 Sebastian Redl <sebastian.redl at getdesigned.at>:
>   
>> AttributeList ... interesting. So it's defined out-of-line since the delete
>> needs the full definition, while all existing uses of AttributeList leak the
>> object and thus are satisfied with the declaration.
>> I'll add AttributeList to the things that need to have their ownership
>> straightened out.
>>
>>     
> I have changes fixing this leakages by delete'ing in my local branch.
> Maybe just use llvm::OwningPtr<AttributeList> instead plain C pointers
> in ActOn*.
> This would enforce taking ownership by Action. If this is ok, please
> let me know and I  will submit this change.
>   
Yes, we'll want to use OwningPtr and other smart pointer for such 
arguments. If you already have a patch doing that, it would be great; if 
not, I'll get to it eventually.

Sebastian