[cfe-dev] Parser Stmt/Expr Owning Pointer

[Howard Hinnant]

I haven't traced this down exactly, so I'm not sure there's a  
problem.  But in:

   template <void (Action::*Destroyer)(void*)>
   class ASTMove {
     ASTOwner<Destroyer> &Moved;

   public:
     explicit ASTMove(ASTOwner<Destroyer> &moved) : Moved(moved) {}
     ...

we store a reference to the ASTOwner.  And I also see client code that  
looks like:

     ExprOwner Idx(Actions, ParseAssignmentExpression());
     if (Idx.isInvalid()) {
       SkipUntil(tok::r_square);
       return Idx.move();
     }

Are we in danger of returning a reference to the local variable Idx?

-Howard