[cfe-dev] [PATCH] Move some code into GRSimpleVals

[Zhongxing Xu]

>
> This is an excellent idea, but I don't think putting this logic in
> GRSimpleVals is the right place.  This is really a property of the
> particular implementation of Store, since that handles the abstraction of
> "memory".  Specifically, this logic seems tied to BasicStore and
> BasicStoreManager respectively.
>
> I think the most logical place would be to put it in BasicStoreManager's
> implementation of "getInitialStore()".  We can either pass LiveVariables& to
> getInitialStore(), or pass GRStateManager& to getInitialStore() (and migrate
> the LiveVariables& instance variable from GRExprEngine to GRStateManager).
>
> Ted
>

Done.

This patch extends BasicStoreManager::getInitialStore() to include code that
symbolicates input variables.
It has two simplifications from the original code:
1. Local variables are not handled, since they are handled in
GRExprEngine::VisitDeclStmt().
2. Removes redundant handle of ImplicitParamDecl, since it is a subclass of
VarDecl.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20080819/e08d4070/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: getInitialStore.patch
Type: application/octet-stream
Size: 7383 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20080819/e08d4070/attachment.obj>