[cfe-dev] Objc Apple Runtime and constant strings

[David Chisnall]

On 13 Aug 2008, at 00:13, Jean-Daniel Dupas wrote:

> Just a question.
>
> I saw a patch commited today to add support for constant strings in
> the Apple runtime. Is there a reason to reimplement the constant
> string generation and not simply call  GetAddrOfConstantCFString ?
>
> llvm::Constant *CGObjCMac::GenerateConstantString(const std::string
> &String) {
> 	return CGM:: GetAddrOfConstantCFString(String);
> }

When I factored constant strings out into the runtime-specific code,  
I left a note above GetAddrOfConstantCFString saying it should be  
moved into an Apple runtime class when one existed.  I don't know why  
this was not done.

David