[cfe-dev] Patch for IdentifierResolver

Chris Lattner clattner at apple.com
Mon Apr 14 16:00:32 PDT 2008


On Apr 14, 2008, at 2:33 PM, Steve Naroff wrote:

>>>> And BTW, now that there is a DeclContext, how about merging
>>>> File/BlockVarDecl into a single VarDecl ?
>>>
>>> When you added DeclContext, this was my thought as well.  
>>> Unfortunately, I was unable to come up with a benefit (other than  
>>> removing a class). I don't believe it simplifies the code or saves  
>>> any space (especially since we still need ParmVarDecl).
>>
>> I think a simplified Decl class hierarchy is a win!
>>
>
> Sure, but we will still need predicates on VarDecl (isFile, isBlock).

Sure, similir to "isglobaldecl"

> Would you like me to make this change?

Sounds great, please do!

-Chris



More information about the cfe-dev mailing list