[cfe-dev] Fixes for References

[Chris Lattner]

>> This is logically independent from the rest of the patch.  I'd  
>> like to eventually remove the return value of  
>> DefaultFunctionArrayConversion, so please remove this piece.
>
> That would break the references stuff. The "stripping of the  
> references" is why I made this change. Otherwise, we get a  
> reference type from
>
>   QualType LHSTy = LHSExp->getType(), RHSTy = RHSExp->getType();
>
> And it fails below. If you're going to remove the return value of  
> DefaultFunctionArrayConversion, then we'd have to do yet another  
> stripping of the reference afterwards.

That's the problem: after calling DefaultFunctionArrayConversion, the  
expr returned should have its reference stripped off with an implicit  
conversion.

One invariant is that the type (current) returned by  
DefaultFunctionArrayConversion should always be the type of the expr.

-Chris