[clang] [llvm] [HLSL][SPIR-V] Add support for SV_Target semantic (PR #168743)

[Steven Perron via cfe-commits]

Nathan =?utf-8?q?Gauër?= <brioche at google.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/168743 at github.com>


================
@@ -2,6 +2,6 @@
 // RUN: %clang_cc1 -triple spirv-pc-vulkan1.3-pixel -finclude-default-header -x hlsl -verify -o - %s
 
 float4 main(float4 a : A) : SV_Position {
-// expected-error at -1 {{attribute 'SV_Position' is unsupported in 'pixel' shaders, requires one of the following: pixel, vertex}}
+// expected-error at -1 {{semantic 'SV_Position' is unsupported as output for stage pixel}}
----------------
s-perron wrote:

This message seem less informative, and does not read as well.

Could you do something like:

semantic 'SV_Position' is unsupported in 'pixel' shaders as an output, requires one of the following: pixel input, vertex input or output


https://github.com/llvm/llvm-project/pull/168743