[clang] [LifetimeSafety] Optimize loan propagation by separating persistent and block-local origins (PR #165789)

[LLVM Continuous Integration via cfe-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-ubsan` running on `sanitizer-buildbot9` while building `clang` at step 2 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/85/builds/15388

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 2 (annotate) failure: 'python ../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py' (failure)
...
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using ld.lld: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/ld.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/main.py:74: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds.
-- Testing: 92240 tests, 72 workers --
Testing:  0.. 10.. 20
FAIL: Clang-Unit :: ./AllClangUnitTests/11/97 (22940 of 92240)
******************** TEST 'Clang-Unit :: ./AllClangUnitTests/11/97' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:/home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/tools/clang/unittests/./AllClangUnitTests-Clang-Unit-2113160-11-97.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=97 GTEST_SHARD_INDEX=11 /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/tools/clang/unittests/./AllClangUnitTests
--

Script:
--
/home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/tools/clang/unittests/./AllClangUnitTests --gtest_filter=LifetimeAnalysisTest.PointersInACycle
--
/home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/clang/lib/Testing/TestAST.cpp:49: Failure
Failed
input.cc:20:19: error: unknown type name 'B'
   20 |         p3 = temp;B
      |                   ^


/home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/clang/lib/Testing/TestAST.cpp:49: Failure
Failed
input.cc:21:9: error: expected unqualified-id
   21 |         POINT(in_loop);
      |         ^
input.cc:2:32: note: expanded from macro 'POINT'
    2 |       #define POINT(name) void("__lifetime_test_point_" #name)
      |                                ^


/home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/clang/lib/Testing/TestAST.cpp:49: Failure
Failed
input.cc:21:9: error: expected ')'
   21 |         POINT(in_loop);
      |         ^
input.cc:2:32: note: expanded from macro 'POINT'
    2 |       #define POINT(name) void("__lifetime_test_point_" #name)
      |                                ^


/home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/clang/unittests/Analysis/LifetimeSafetyTest.cpp:76: Failure
Step 11 (stage2/ubsan check) failure: stage2/ubsan check (failure)
...
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using ld.lld: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/ld.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/main.py:74: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds.
-- Testing: 92240 tests, 72 workers --
Testing:  0.. 10.. 20
FAIL: Clang-Unit :: ./AllClangUnitTests/11/97 (22940 of 92240)
******************** TEST 'Clang-Unit :: ./AllClangUnitTests/11/97' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:/home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/tools/clang/unittests/./AllClangUnitTests-Clang-Unit-2113160-11-97.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=97 GTEST_SHARD_INDEX=11 /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/tools/clang/unittests/./AllClangUnitTests
--

Script:
--
/home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/tools/clang/unittests/./AllClangUnitTests --gtest_filter=LifetimeAnalysisTest.PointersInACycle
--
/home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/clang/lib/Testing/TestAST.cpp:49: Failure
Failed
input.cc:20:19: error: unknown type name 'B'
   20 |         p3 = temp;B
      |                   ^


/home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/clang/lib/Testing/TestAST.cpp:49: Failure
Failed
input.cc:21:9: error: expected unqualified-id
   21 |         POINT(in_loop);
      |         ^
input.cc:2:32: note: expanded from macro 'POINT'
    2 |       #define POINT(name) void("__lifetime_test_point_" #name)
      |                                ^


/home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/clang/lib/Testing/TestAST.cpp:49: Failure
Failed
input.cc:21:9: error: expected ')'
   21 |         POINT(in_loop);
      |         ^
input.cc:2:32: note: expanded from macro 'POINT'
    2 |       #define POINT(name) void("__lifetime_test_point_" #name)
      |                                ^


/home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/clang/unittests/Analysis/LifetimeSafetyTest.cpp:76: Failure
Step 14 (stage3/ubsan check) failure: stage3/ubsan check (failure)
...
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build2_ubsan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build2_ubsan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build2_ubsan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using ld.lld: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build2_ubsan/bin/ld.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build2_ubsan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build2_ubsan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:531: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build2_ubsan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/utils/lit/lit/main.py:74: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds.
-- Testing: 88780 tests, 72 workers --
Testing:  0.. 10.. 20
FAIL: Clang-Unit :: ./AllClangUnitTests/11/97 (22872 of 88780)
******************** TEST 'Clang-Unit :: ./AllClangUnitTests/11/97' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:/home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build2_ubsan/tools/clang/unittests/./AllClangUnitTests-Clang-Unit-3645917-11-97.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=97 GTEST_SHARD_INDEX=11 /home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build2_ubsan/tools/clang/unittests/./AllClangUnitTests
--

Script:
--
/home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build2_ubsan/tools/clang/unittests/./AllClangUnitTests --gtest_filter=LifetimeAnalysisTest.PointersInACycle
--
/home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/clang/lib/Testing/TestAST.cpp:49: Failure
Failed
input.cc:20:19: error: unknown type name 'B'
   20 |         p3 = temp;B
      |                   ^


/home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/clang/lib/Testing/TestAST.cpp:49: Failure
Failed
input.cc:21:9: error: expected unqualified-id
   21 |         POINT(in_loop);
      |         ^
input.cc:2:32: note: expanded from macro 'POINT'
    2 |       #define POINT(name) void("__lifetime_test_point_" #name)
      |                                ^


/home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/clang/lib/Testing/TestAST.cpp:49: Failure
Failed
input.cc:21:9: error: expected ')'
   21 |         POINT(in_loop);
      |         ^
input.cc:2:32: note: expanded from macro 'POINT'
    2 |       #define POINT(name) void("__lifetime_test_point_" #name)
      |                                ^


/home/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/clang/unittests/Analysis/LifetimeSafetyTest.cpp:76: Failure

```

</details>

https://github.com/llvm/llvm-project/pull/165789