[clang-tools-extra] [clang-tidy] support query based custom check (PR #131804)

[Congcong Cai via cfe-commits]

HerrCai0907 wrote:

> I see builds failing in the link, per the report from @llvm-ci above: https://lab.llvm.org/buildbot/#/builders/145/builds/9815
> 
> ```
> FAILED: lib/libclangTidy.so.22.0git 
> : && /home/buildbots/llvm-external-buildbots/clang.19.1.7/bin/clang++ --gcc-toolchain=/gcc-toolchain/usr -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete -Wl,--color-diagnostics   -Wl,--gc-sections  -Xlinker --dependency-file=tools/clang/tools/extra/clang-tidy/CMakeFiles/clangTidy.dir/link.d -shared -Wl,-soname,libclangTidy.so.22.0git -o lib/libclangTidy.so.22.0git tools/clang/tools/extra/clang-tidy/CMakeFiles/obj.clangTidy.dir/ClangTidy.cpp.o tools/clang/tools/extra/clang-tidy/CMakeFiles/obj.clangTidy.dir/ClangTidyCheck.cpp.o tools/clang/tools/extra/clang-tidy/CMakeFiles/obj.clangTidy.dir/ClangTidyModule.cpp.o tools/clang/tools/extra/clang-tidy/CMakeFiles/obj.clangTidy.dir/ClangTidyDiagnosticConsumer.cpp.o tools/clang/tools/extra/clang-tidy/CMakeFiles/obj.clangTidy.dir/ClangTidyOptions.cpp.o tools/clang/tools/extra/clang-tidy/CMakeFiles/obj.clangTidy.dir/ClangTidyProfiling.cpp.o tools/clang/tools/extra/clang-tidy/CMakeFiles/obj.clangTidy.dir/ExpandModularHeadersPPCallbacks.cpp.o tools/clang/tools/extra/clang-tidy/CMakeFiles/obj.clangTidy.dir/GlobList.cpp.o tools/clang/tools/extra/clang-tidy/CMakeFiles/obj.clangTidy.dir/NoLintDirectiveHandler.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/lib:"  lib/libclangTooling.so.22.0git  lib/libclangStaticAnalyzerFrontend.so.22.0git  lib/libclangStaticAnalyzerCore.so.22.0git  lib/libclangFormat.so.22.0git  lib/libclangFrontend.so.22.0git  lib/libclangSerialization.so.22.0git  lib/libclangToolingCore.so.22.0git  lib/libclangRewrite.so.22.0git  lib/libclangAnalysis.so.22.0git  lib/libclangASTMatchers.so.22.0git  lib/libclangAST.so.22.0git  lib/libclangLex.so.22.0git  lib/libclangBasic.so.22.0git  lib/libLLVMFrontendOpenMP.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/lib && :
> ld.lld: error: undefined symbol: clang::tidy::custom::registerCustomChecks(clang::tidy::ClangTidyOptions const&, clang::tidy::ClangTidyCheckFactories&)
> >>> referenced by ClangTidy.cpp
> >>>               tools/clang/tools/extra/clang-tidy/CMakeFiles/obj.clangTidy.dir/ClangTidy.cpp.o:(clang::tidy::ClangTidyASTConsumerFactory::ClangTidyASTConsumerFactory(clang::tidy::ClangTidyContext&, llvm::IntrusiveRefCntPtr<llvm::vfs::OverlayFileSystem>))
> >>> referenced by ClangTidy.cpp
> >>>               tools/clang/tools/extra/clang-tidy/CMakeFiles/obj.clangTidy.dir/ClangTidy.cpp.o:(clang::tidy::ClangTidyASTConsumerFactory::createASTConsumer(clang::CompilerInstance&, llvm::StringRef))
> >>> referenced by ClangTidy.cpp
> >>>               tools/clang/tools/extra/clang-tidy/CMakeFiles/obj.clangTidy.dir/ClangTidy.cpp.o:(clang::tidy::getAllChecksAndOptions(bool, bool))
> clang++: error: linker command failed with exit code 1 (use -v to see invocation)
> ```

I don't find any cmake build issue. According to error message, it looks like `clangTidyCustomModule` does not be linked. Are there anyone can reproduce this build issue?


https://github.com/llvm/llvm-project/pull/131804