[PATCH] D55424: [analyzer] Supply all checkers with a shouldRegister function

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 20 15:39:27 PST 2019


Szelethus added a comment.

In D55424#1326397 <https://reviews.llvm.org/D55424#1326397>, @NoQ wrote:

> Should we also pass `CheckerManager` into `shouldRegister...`? Or is it entirely useless?


I wouldn't say useless, but I'm struggling to come up with an example where registering would depend on non-language dependent reasons. I'm stuck on rebasing my patches, so I'll give it a thought whether it's worth the chore to change everything (but where I'd like to leave a system for the long term, doing extra work shouldn't be a major concern).


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55424/new/

https://reviews.llvm.org/D55424





More information about the cfe-commits mailing list