[PATCH] D45978: dllexport const variables must have external linkage.

[Reid Kleckner via Phabricator via cfe-commits]

rnk added a comment.

I still feel like there has to be a more uniform way to handle this. Basically anything with __declspec(dllexport) on it is effectively upgraded to external linkage.



================
Comment at: lib/Sema/SemaDeclAttr.cpp:6491
+  if (auto *VD = dyn_cast<VarDecl>(D)) {
+    if (getLangOpts().CPlusPlus && getLangOpts().MSVCCompat &&
+        VD->getType().isLocalConstQualified() &&
----------------
This still shouldn't be under -fms-compatibility, it's really part of the main dllexport feature and doesn't need to be conditional on anything at this point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D45978/new/

https://reviews.llvm.org/D45978